-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abhilash/ArcGateway-Feature #7753
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
connectedk8s connect | cmd connectedk8s connect added parameter configuration_protected_settings |
||
connectedk8s connect | cmd connectedk8s connect added parameter configuration_settings |
||
connectedk8s connect | cmd connectedk8s connect added parameter enable_gateway |
||
connectedk8s connect | cmd connectedk8s connect added parameter gateway_resource_id |
Hi @9lash, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
For more info about extension versioning, please refer to Extension version schema |
Please fix CI issues |
…form prelim checks
…e-cli-extensions into abiyer/add-arcgateway
…e-cli-extensions into abiyer/add-arcgateway
…e-cli-extensions into abiyer/add-arcgateway
@@ -3,6 +3,11 @@ | |||
Release History | |||
=============== | |||
|
|||
1.8.0 | |||
++++++ | |||
* Add support for api version 07-01-2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there was a real requirement to keep these as a single change, it would have been nice to see these are two PRs so that the specific changes for the two were clearly communicated.
@@ -51,6 +55,10 @@ def load_arguments(self, _): | |||
c.argument('container_log_path', help='Override the default container log path to enable fluent-bit logging') | |||
c.argument('skip_ssl_verification', action='store_true', help='Skip SSL verification for any cluster connection.') | |||
c.argument('yes', options_list=['--yes', '-y'], help='Do not prompt for confirmation.', action='store_true') | |||
c.argument('enable_gateway', options_list=['--enable-gateway'], help='Pass this value to enable Arc Gateway.') | |||
c.argument('gateway_resource_id', options_list=['--gateway-resource-id'], help='ArmID of the Arc Gateway resource.') | |||
c.argument('configuration_settings', options_list=['--configuration-settings', '--config'], action=AddConfigurationSettings, nargs='+', help='Configuration Settings as key=value pair. Repeat parameter for each setting. Do not use this for secrets, as this value is returned in response.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would feature_settings
and protected_feature_settings
be a better name given these relate to features?
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.